Internal Compiler Error when building AGX plugin on VS2017

ytazz · June 21, 2018, 6:39am

Hi

I observed internal compiler error (C1001) when building
CnoidAGXDynamicsPlugin and
CnoidAGXBodyExtensionPlugin

agx version is 2.21.1.1
Visual Studio 2017 (15.7.4)

This error can be avoided by disabling whole-program-optimization (/GL)
for these projects.

It might be better to disable this option by default.

yosuke · July 2, 2018, 11:54pm

This may be (just may be) the related info. They (MS-VS developer) says that the problem has been fixed in the very recent version of the Visual C++ compiler, but AGX library may not be compiled using the latest compiler (also, mismatch of the compiler version may lead us to the link-time-optimization error).

I agree that disabling the /GL option is a nice solution in this case. It only disables the link-time-optimization while optimization to each modules will still be applied. So the overall performance loss should be very limited.

yosuke · July 3, 2018, 6:01am

Information for the other participant who may face with this issue.

Visual C++ whole-program-optimization option is defined in the following line in the choreonoid CMakeList.txt file and can be turned off by using cmake GUI when you generate Visual C++ project file (default value is ON).

github.com

s-nakaoka/choreonoid/blob/master/CMakeLists.txt#L163


      
          if(UNIX)
            set(CHOREONOID_DEFAULT_FVISIBILITY_HIDDEN ON)
          
            set(compiler_general_options "-Wreturn-type")
            set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -finline-functions")
          
            option(ENABLE_NATIVE_CPU_ARCHITECTURE "Use the -march=native option to enable instruction set supported by the native processor architecture" OFF)
            if(ENABLE_NATIVE_ARCHITECTURE)
              set(compiler_general_options "${compiler_general_options} -march=native")
            endif()
          
            option(CHECK_UNRESOLVED_SYMBOLS "check unresolved symbols in the object files when creating shared libraries" OFF)
            if(CHECK_UNRESOLVED_SYMBOLS)
              set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,--unresolved-symbols=ignore-in-shared-libs -Wl,--warn-unresolved-symbols")
            endif()
          
            option(PUT_EXTRA_WARNINGS "Put extra warnings in compile" OFF)
            if(PUT_EXTRA_WARNINGS)
              set(compiler_general_options "${compiler_general_options} -Wall -Wunused -Woverloaded-virtual -Wsign-compare")
              # -Wparentheses -Wformat=2 -Wformat-nonliteral -Wunknown-pragmas -Wunused-parameter -Wuninitialized -Winit-self -pedantic -Wconversion -Wno-variadic-macros -Wno-long-long -Wno-import -Wno-missing-braces
            endif()

nakaoka · July 24, 2018, 5:06am

Thank you for informing us of this.
I’ll disable this option by default.
Please wait for a while to reflect on the github repository due to circumstances.

nakaoka · July 24, 2018, 12:08pm

I pushed the source code to which this modification was applied.